[FEATURE] TracingGanttChart: add search functionality#661
Merged
andreasgerstmayr merged 3 commits intoMay 26, 2026
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
jgbernalp
reviewed
May 22, 2026
| } | ||
|
|
||
| function handleKeyDown(e: React.KeyboardEvent): void { | ||
| if (e.key === 'Enter') { |
Contributor
There was a problem hiding this comment.
should this be guarded with hasMatches?
Contributor
Author
There was a problem hiding this comment.
Good catch!
The buttons are disabled in this case, but the keypress event still fires and would produce a NaN. I added the guard.
jgbernalp
approved these changes
May 24, 2026
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add search functionality to the TracingGanttChart. It searches in the following fields:
Screenshots
ganttchart_search.mp4
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes